Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Enable CIDER composer by default #3519

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Enable CIDER composer by default #3519

merged 2 commits into from
Oct 4, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Oct 4, 2019 •
edited
Loading

Also convert the setting to a watched setting to apply in realtime.

Paired with element-hq/element-web#11047

@turt2live
Enable CIDER composer by default
853c522 
Also convert the setting to a watched setting to apply in realtime.
@turt2live turt2live added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Oct 4, 2019
turt2live added a commit to element-hq/element-web that referenced this pull request Oct 4, 2019
@turt2live
Remove docs for CIDER feature
98b4681 
See matrix-org/matrix-react-sdk#3519
@turt2live turt2live mentioned this pull request Oct 4, 2019
Merged
@turt2live turt2live requested a review from a team October 4, 2019 05:23
t3chguy
t3chguy approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

src/components/structures/RoomView.js Outdated Show resolved Hide resolved
src/settings/Settings.js Outdated Show resolved Hide resolved
@t3chguy
DRY and fix useCiderComposer being in both labs and preferences
e200193 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team October 4, 2019 09:15
@bwindels bwindels removed the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Oct 4, 2019
@bwindels bwindels requested review from bwindels and removed request for a team October 4, 2019 09:16
bwindels
bwindels approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@t3chguy
Copy link
Member

t3chguy commented Oct 4, 2019

Blocked on updated e2e tests

@t3chguy t3chguy added the blocked label Oct 4, 2019
@bwindels bwindels mentioned this pull request Oct 4, 2019
Merged
@t3chguy t3chguy removed the blocked label Oct 4, 2019
@t3chguy t3chguy merged commit fba646d into develop Oct 4, 2019
@turt2live turt2live deleted the travis/enable-cider branch October 5, 2019 02:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@bwindels bwindels bwindels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turt2live @t3chguy @bwindels